[FFmpeg-devel] [PATCH 1/2] avcodec: Add interface to motion estimation

[Ronald S. Bultje]

Hi,

On Sat, Aug 29, 2015 at 10:23 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> From: Michael Niedermayer <michael at niedermayer.cc>
>
> This is needed for vf_mcfps, no codec related structs are part of the
> public interface
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/Makefile   |    2 +-
>  libavcodec/avme.c     |  138
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/avme.h     |   30 +++++++++++
>  libavcodec/internal.h |    2 +
>  libavcodec/snow.c     |   30 +++++++++++
>  libavcodec/version.h  |    2 +-
>  6 files changed, 202 insertions(+), 2 deletions(-)
>  create mode 100644 libavcodec/avme.c
>  create mode 100644 libavcodec/avme.h


This is just wrapper code. It may fix an interface issue, but not the
implementation issue. Can you make ME available without depending on snow?
I can't imagine this is hard, don't we have an mpeg encoder, doesn't that
use ME also? What if I want a build with just decoders and filters, but I
want to include vf_mcfps?

I'd like to think of snow as a highly obscure codec that nobody ever needs.
Making it a central implementation piece for our best fps filter is ...
highly questionable.

Ronald