[FFmpeg-devel] [PATCH] avfilter: add panorama filter

[Clément Bœsch]

On Sat, Dec 05, 2015 at 01:20:40PM -0500, Ganesh Ajjanagadde wrote:
[...]
> >> +
> >> +    AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts);
> >> +    if (!fmts_list)
> >> +        return AVERROR(ENOMEM);
> >> +    return ff_set_common_formats(ctx, fmts_list);
> 
> still leaky - when fmts_list is allocated correctly, and
> ff_set_common_formats fails. Proof: use the patch used for the proof
> regarding af_agate.
> 
> @Clement: found this while examining avfilter/vf_curves. Can you
> please do the needful there?
> 

i lost track of what's happening here, but isn't ff_set_common_formats()
freeing the list in case of failure?

That pattern is likely used in many places.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151205/ae9acace/attachment.sig>