[FFmpeg-devel] [PATCHv2] avcodec/aacsbr_tablegen: always initialize tables at runtime

Rostislav Pehlivanov atomnuker at gmail.com
Wed Dec 9 11:30:46 CET 2015


On Sat, 2015-12-05 at 14:48 -0500, Ganesh Ajjanagadde wrote:
>  libavcodec/Makefile                 |  8 ++------
>  libavcodec/aacsbr_fixed_tablegen.c  | 39 -------------------------
> ------------
>  libavcodec/aacsbr_fixed_tablegen.h  |  4 ----
>  libavcodec/aacsbr_tablegen.c        | 39 -------------------------
> ------------
>  libavcodec/aacsbr_tablegen.h        |  4 ----
>  libavcodec/aacsbr_tablegen_common.h |  4 ----
>  6 files changed, 2 insertions(+), 96 deletions(-)
>  delete mode 100644 libavcodec/aacsbr_fixed_tablegen.c
>  delete mode 100644 libavcodec/aacsbr_tablegen.c

LGTM, sorry for the delay

Another option would be moving everything from aacsbr_tablegen_common.h
to aacsbrdata.h but that file is big enough as it is and contains only
tables. So in this case it's IMO better to just
let aacsbr_tablegen_common.h handle the SBR table generating.

Thanks


More information about the ffmpeg-devel mailing list