[FFmpeg-devel] [PATCH] QSV : making three qsv routines public

[Ivan Uskov]

Hello Hendrik,

Thursday, December 10, 2015, 1:10:59 PM, you wrote:

>>>> This patch expose 3 QSV functions as public.
>>>> This is needed because the VPP needs access to these functions too.
>>>>
>>>> Please review.
>>>>
>>
>> HL> public API is not allowed to use config.h, it needs to be config and
>> HL> OS agnostic.
>> Any qsv_* function can not be public since are all under CONFIG_QSV, correct?
>>

HL> Thats not necessarily true, if its supposed to be public API, it just
HL> has to always be present, so it would have to be changed to just do
HL> nothing and return an error if QSV is not enabled, but the functions
HL> still exist.
But   it  is exactly that Sven did, there are dummies for all public function
into the qsv_api.c for the case if CONFIG_QSV==0
What is wrong then?



-- 
Best regards,
 Ivan                            mailto:ivan.uskov at nablet.com