[FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

Mats Peterson matsp888 at yahoo.com
Fri Dec 11 13:07:51 CET 2015


Regarding the following statement by you:
"Unrelated: It is a mystery to me how using the function that 
allows parsing stsd atoms to parse an stsd atom can be called 
a "hack", even more so when this is done in existing code."
It's really a bad kludge, if you think about it. It's of course much more logical to use the private data directly, as I have done in my latest patch.
Mats
 -- 
Mats Peterson
http://matsp888.no-ip.org/~mats/
      From: Carl Eugen Hoyos <cehoyos at ag.or.at>
 To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org> 
 Sent: Friday, December 11, 2015 12:42 PM
 Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly
   
On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote:
> OK, here is an improved version of my previous patch of 
> matroskadec.c that manages the palette itself without calling 
> code in mov.c. I have borrowed some code from it

This is completely unacceptable afaict.

Unrelated: It is a mystery to me how using the function that 
allows parsing stsd atoms to parse an stsd atom can be called 
a "hack", even more so when this is done in existing code.

Please stop top-posting here and please send separate patches 
made with git format-patch for separate issues.

Finally, please try to attribute patches you send here to the 
original author, thank you.

Carl Eugen


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


 


More information about the ffmpeg-devel mailing list