[FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

[Mats Peterson]

Sorry for my typos. "Privata" really means "private data" ;)

 
Mats
-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


----- Original Message -----
From: Mats Peterson <matsp888-at-yahoo.com at ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Sent: Saturday, December 12, 2015 12:22 PM
Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c:	Handle	palettized	QuickTime video properly

21 is one odd number, to start with. It will make the privata end in the middle of the vendor fourcc, which is often 'appl'.


Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


----- Original Message -----
From: Mats Peterson <matsp888-at-yahoo.com at ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Sent: Saturday, December 12, 2015 12:17 PM
Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle    palettized    QuickTime video properly

Obviously that private data is cropped in some way then, since the minimum size of a video sample description in QuickTime video is 86 bytes.


Mats

-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


----- Original Message -----
From: Michael Niedermayer <michaelni at gmx.at>
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Sent: Saturday, December 12, 2015 11:58 AM
Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized    QuickTime video properly

On Fri, Dec 11, 2015 at 11:32:13AM +0000, Mats Peterson wrote:



> OK, here is an improved version of my previous patch of matroskadec.c that manages the palette itself without calling code in mov.c. I have borrowed some code from it, though, and I'm including qtpalette.h. One thing I don't understand is why the minimum private data size for V_QUICKTIME has been the mysterioius value 21 so far, since 86 is the minimum size for a video sample description without a palette. So I changed that. As I said before, I have also changed the minimum private data size for A_QUICKTIME from 86 to 36, since 36 is the size of a version 0 sound sample description.
> Mats -- 
> Mats Peterson
> http://matsp888.no-ip.org/~mats/

>  matroskadec.c |   94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 89 insertions(+), 5 deletions(-)
> 6d1e32a75c7d8de7dfb02756a135ad7855c49b90  matroskadec.c.diff
> --- matroskadec.c.orig    2015-12-08 11:01:40.640478749 +0100
> +++ matroskadec.c    2015-12-11 12:00:13.000000000 +0100

this breaks demuxing of the video stream from
output-ffmpeg-20140109-git-c0a33c4.mkv
(google should find a url for this)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel






_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel