[FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

Mats Peterson matsp888 at yahoo.com
Mon Dec 14 06:29:01 CET 2015


On 12/14/2015 03:40 AM, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me.
> I can't see how duplicating the code from mov.c could be acceptable.
>
> Please comment, Carl Eugen
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

You can't? Then why did Hendryk tell me that calling code in another 
demuxer was a bad idea? That's why I changed the whole thing. And it IS 
a bad idea, since that code in mov.c is reading from the FILE, which is 
totally overkill when you already have the private data to work with. 
It's not up to you to decide this, please leave it to someone who knows 
the issue better than you.

Mats
-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


More information about the ffmpeg-devel mailing list