[FFmpeg-devel] [PATCH] nuv: reject negative fps rate

[Andreas Cadhalpun]

On 18.12.2015 01:12, Michael Niedermayer wrote:
> On Thu, Dec 17, 2015 at 11:03:15PM +0100, Andreas Cadhalpun wrote:
>> On 16.12.2015 23:53, Michael Niedermayer wrote:
>>> On Wed, Dec 16, 2015 at 08:56:55PM +0100, Andreas Cadhalpun wrote:
>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>>>> ---
>>>>  libavformat/nuv.c | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>
>>> looks logical iam not nuv maintainer though and i dont know if all
>>> files have fps set
>>
>> I don't know that either, so I'm attaching a version of this patch
>> that permits 0 fps. Which version do you prefer?
> 
> no real preferrance
> i might slightly tend to allow fps == 0
> but if 0 is disallowed and it occurs, people will tell us and we will
> fix that
> iam fine with either

OK.

> theres no spec or reference that can be "checked" i assume ?

I haven't found one (and this is not exactly a very popular format).

Best regards,
Andreas