[FFmpeg-devel] [PATCH] Adding frame side data about green metadata

[Nicolas Derouineau]

Please find here attached the updated patch with the suggested modifications.

Best regards,

Nicolas DEROUINEAU

________________________________________
De : ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> de la part de Michael Niedermayer <michael at niedermayer.cc>
Envoyé : mercredi 23 décembre 2015 14:49
À : FFmpeg development discussions and patches
Objet : Re: [FFmpeg-devel] [PATCH] Adding frame side data about green   metadata

On Wed, Dec 23, 2015 at 12:43:48PM +0000, Nicolas Derouineau wrote:
> > Sorry if I missed something:
> > What is green metadata?
>
> Greenmetadata is a set of metrics specified in ISO/IEC 23001-11.
>
> They are used to predict the decoding complexity (in terms of cycles) of AVC frames. It is useful to perform DVFS (ie: CPU frequency scaling) in order to reduce decoder power consumption.
>
> By the way, I'm not sure the patch was correctly attached. I'm trying one more time to attach it.
[...]

> index e69de29..7b383e7 100644
> --- a/libavutil/greenmetadata.h
> +++ b/libavutil/greenmetadata.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (c) 2015 Nicolas DEROUINEAU <nicolas.derouineau at vitec.com>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVUTIL_GREENMD_H
> +#define AVUTIL_GREENMD_H
> +
> +#include <stdint.h>

> +#include <libavcodec/h264.h>

libavutil should not include stuff from libavcodec
also it would be "libavcodec/h264.h" not <libavcodec/h264.h>


[...]

--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-frame-side-data-when-SEI-green-metadata-are-dete.patch
Type: text/x-patch
Size: 3966 bytes
Desc: 0001-Add-frame-side-data-when-SEI-green-metadata-are-dete.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151224/b99db1f1/attachment.bin>