[FFmpeg-devel] [PATCH 1/3] avformat/http: Added http_proxy option

[Nicolas George]

Le sextidi 6 nivôse, an CCXXIV, Joel Holdsworth a écrit :
>      { "seekable", "control seekability of connection", OFFSET(seekable), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, D },
>      { "chunked_post", "use chunked transfer-encoding for posts", OFFSET(chunked_post), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, E },
> +    { "http_proxy", "The HTTP proxy to communicate via", OFFSET(http_proxy), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
>      { "headers", "set custom HTTP headers, can override built in default headers", OFFSET(headers), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },

The wording and capitalization are inconsistent with the other options.

Apart from that, I see nothing wrong with the patch, but I am not maintainer
of this part of the code.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151226/9a7f9a5f/attachment.sig>