[FFmpeg-devel] [PATCH v9] lavf: palettized QuickTime video in Matroska

Michael Niedermayer michael at niedermayer.cc
Mon Dec 28 10:34:50 CET 2015


On Mon, Dec 28, 2015 at 03:10:18AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michael <at> niedermayer.cc> writes:
> 
> > Patch splited in move and matroska part
> > i removed this memcpy() for now from what i 
> > commited as there is clearly no consenus on it
> 
> I would really have appreciated a real review:
> Apart from the unrelated audio fix

what audio fix ?


> a significant
> part of the patch was written by me.

If thats the case then the commit message of the patch should have
contained credits or it should have added credits to the file header
what significant part of your code was used ?

Should i revert the patches ?
do you have another suggestion ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151228/08fbb04d/attachment.sig>


More information about the ffmpeg-devel mailing list