[FFmpeg-devel] [PATCH]Enable pic on OSX for x86_64

[Ronald S. Bultje]

Hi,

On Sat, Feb 7, 2015 at 2:53 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Michael Niedermayer <michaelni <at> gmx.at> writes:
>
> > > -        enabled x86_64 && objformat="macho64"
> > > +        enabled x86_64 && objformat="macho64" && enable pic
> > >          enabled_any pic shared ||
> >
> > can you explain what fails without this ?
> >
> > this:
> > check_cpp_condition stdlib.h "defined(__PIC__) ||
> > defined(__pic__) || defined(PIC)" && enable_weak pic
> >
> > should set pic i think
>
> __PIC__ is not defined because of -mdynamic-no-pic
> that gets added earlier to the icc cfags.
> The others are never set.
>
> I believe that clang ignores -mdynamic-no-pic if
> -DPIC is set while icc fails for "-mdynamic-no-pic
> -DPIC".


I'm not sure we should ever set -mdynamic-no-pic on Mac x86-64?

Ronald