[FFmpeg-devel] [PATCH] Factorize avpriv_mirror() out

Clément Bœsch u at pkh.me
Sun Jan 4 10:26:00 CET 2015


On Sun, Jan 04, 2015 at 12:43:26AM -0300, James Almer wrote:
> On 04/01/15 12:32 AM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/dirac_dwt.c     |   30 +++++++------------
> >  libavcodec/snow_dwt.c      |   70 +++++++++++++++++++-------------------------
> >  libavfilter/transform.c    |   14 ++-------
> >  libavfilter/vf_owdenoise.c |   17 +++--------
> >  libavfilter/vf_sab.c       |   19 ++----------
> >  libavutil/common.h         |   14 +++++++++
> >  6 files changed, 63 insertions(+), 101 deletions(-)
> 
> libavutil/common.h is an installed header. Wouldn't it make more sense to use the av_ 
> prefix like every other function above this one?

Or just let it half private by having it in an internal.h header.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150104/e8846b44/attachment.asc>


More information about the ffmpeg-devel mailing list