[FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

[Philip Langdale]

On 2015-01-15 23:48, Nicolas George wrote:
> Le septidi 27 nivôse, an CCXXIII, Timo Rothenpieler a écrit :
>> +        av_reduce(&dw, &dh, avctx->sample_aspect_ratio.num, 
>> avctx->sample_aspect_ratio.den, 4096);
>> +        ctx->init_encode_params.darHeight = dw;
>> +        ctx->init_encode_params.darWidth = dh;
> 
> Has this been actually tested? "dar" in the API does not seem to be the 
> same
> thing as sample_aspect_ratio in FFmpeg's API.

Right. It is display aspect ratio, not sample aspect ratio. And then you 
have the
45/44 problem, unless that's somehow just affecting me.

--phil