[FFmpeg-devel] [PATCH] snow: remove strange av_assert2

Michael Niedermayer michaelni at gmx.at
Mon Jul 6 02:40:44 CEST 2015

On Sun, Jul 05, 2015 at 09:11:44PM +0200, Andreas Cadhalpun wrote:
> On 03.07.2015 01:04, Michael Niedermayer wrote:
> > On Fri, Jul 03, 2015 at 12:31:31AM +0200, Andreas Cadhalpun wrote:
> >> It asserts that the frame linesize is larger than 37, but it can be
> >> smaller and decoding such frames works. Thus it is unclear what this
> >> assert is good for.
> > 
> > i think it was due to the layout of some temporary /scratch buffer
> > 
> > maybe in the emulated_edge_mc() call in ff_snow_pred_block() but
> > iam not sure
> I couldn't find a problem with the layout of the tmp/scratchbuf buffer
> for small strides.
> > as stride becomes too small its no longer possible to store some elements
> > that is when they are larger
> Can you explain how elements can be too larger to fit?

emulated_edge_mc() writes a block of width x height,
if stride < width this will not work as intended

iam quite unsure if this is the intended thing for the assert to
check, i hthik there was more code that possibly was fixed


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150706/dc6aab0a/attachment.sig>

More information about the ffmpeg-devel mailing list