[FFmpeg-devel] [PATCH]Tell users about Closed Captions in video streams

Hendrik Leppkes h.leppkes at gmail.com
Tue Jul 7 00:05:09 CEST 2015

On Mon, Jul 6, 2015 at 6:32 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> On Monday 06 July 2015 06:18:14 pm Carl Eugen Hoyos wrote:
>> Hendrik Leppkes <h.leppkes <at> gmail.com> writes:
>> > > Attached patch adds "Closed Captions" to the codec
>> > > dump if the video stream contains them.
>> >
>> > Adding fields to a public context which should never
>> > be accessed by the public is a big no-no.
>> What is the alternative?
> As in attached?

If anything it should use the automatic accessor macros, but I still
find it a silly solution.
Any API user could just check the side data of the frames to know if
CCs are available, AVCodecContext doesn't need to track that.

Its an old problem, you're trying to solve a ffmpeg.c problem by
hacking around in avcodec, which is IMHO not a good idea.

- Hendrik

More information about the ffmpeg-devel mailing list