[FFmpeg-devel] [PATCH 2/2] avcodev/libdcadec: implement request_channel_layout

[Michael Niedermayer]

On Tue, Jul 07, 2015 at 03:06:24AM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/libdcadec.c | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/libavcodec/libdcadec.c b/libavcodec/libdcadec.c
> index 4bc3765..796826e 100644
> --- a/libavcodec/libdcadec.c
> +++ b/libavcodec/libdcadec.c

> @@ -36,6 +36,8 @@ typedef struct DCADecContext {
>      int buffer_size;
>  } DCADecContext;
>  
> +static int downmix_warned = 0;

in an application running a long time like something with a
a list of media files, the warning would only be showen for the first
file to which it applies

i think it should rater be in the context and displayed once for each
file it applies to

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150709/9ca20c9f/attachment.sig>