[FFmpeg-devel] [libav-devel] [PATCH 2/2] riff: Use the correct logging context

Michael Niedermayer michael at niedermayer.cc
Sat Jul 11 18:59:00 CEST 2015


On Sat, Jul 11, 2015 at 05:22:04PM +0200, Andreas Cadhalpun wrote:
[...]
> This looks good.
> It has the nice side effect, that it makes it possible to get an explode
> mode working in ff_get_wav_header.
> (Attached is this patch rebased on ffmpeg, since my next riff patch
> depends on this.)

should be ok but please fix these before pushing:

libavformat/asfdec_o.c: In function ‘asf_read_stream_properties’:
libavformat/asfdec_o.c:755:9: warning: passing argument 1 of ‘ff_get_wav_header’ from incompatible pointer type [enabled by default]
libavformat/riff.h:65:5: note: expected ‘struct AVFormatContext *’ but argument is of type ‘struct AVIOContext *’
libavformat/asfdec_o.c:755:9: warning: passing argument 2 of ‘ff_get_wav_header’ from incompatible pointer type [enabled by default]
libavformat/riff.h:65:5: note: expected ‘struct AVIOContext *’ but argument is of type ‘struct AVCodecContext *’
libavformat/asfdec_o.c:755:9: warning: passing argument 3 of ‘ff_get_wav_header’ makes pointer from integer without a cast [enabled by default]
libavformat/riff.h:65:5: note: expected ‘struct AVCodecContext *’ but argument is of type ‘uint32_t’
libavformat/asfdec_o.c:755:9: error: too few arguments to function ‘ff_get_wav_header’
libavformat/riff.h:65:5: note: declared here
make: *** [libavformat/asfdec_o.o] Error 1



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150711/8a87941b/attachment.sig>


More information about the ffmpeg-devel mailing list