[FFmpeg-devel] [PATCH 2/2] avfilter/vf_w3fdif: implement slice threading

Michael Niedermayer michael at niedermayer.cc
Sat Jul 11 21:37:47 CEST 2015


On Sat, Jul 11, 2015 at 07:03:41PM +0000, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/vf_w3fdif.c | 75 ++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 53 insertions(+), 22 deletions(-)

this is about 2x as fast but it breaks the tests
lter-mcdeint-fast
TEST    filter-mcdeint-medium
--- ./tests/ref/fate/filter-w3fdif-simple       2015-07-11 21:11:06.232922890 +0200
+++ tests/data/fate/filter-w3fdif-simple        2015-07-11 21:36:10.972954591 +0200
@@ -1,31 +1,31 @@
 #tb 0: 1/50
-0,         18,         18,        1,   622080, 0xc73774f5
-0,         19,         19,        1,   622080, 0x4ea3a400
-0,         20,         20,        1,   622080, 0x95153cda
-0,         21,         21,        1,   622080, 0xec39bf0b
-0,         22,         22,        1,   622080, 0x94b6f836
-0,         23,         23,        1,   622080, 0xc145c3ee
-0,         24,         24,        1,   622080, 0x4d4cdee2
-0,         25,         25,        1,   622080, 0x193ebc7c
-0,         26,         26,        1,   622080, 0xbd728fd8
-0,         27,         27,        1,   622080, 0xf0f3252f
-0,         28,         28,        1,   622080, 0xc012d20a
-0,         29,         29,        1,   622080, 0x7b5831b2
-0,         30,         30,        1,   622080, 0x464e9622
-0,         31,         31,        1,   622080, 0x46e3c6c0
-0,         32,         32,        1,   622080, 0xa6ec908b
-0,         33,         33,        1,   622080, 0x6a257595
-0,         34,         34,        1,   622080, 0xa6552ecc
-0,         35,         35,        1,   622080, 0xdecd1a91
-0,         36,         36,        1,   622080, 0xfaa53e71
-0,         37,         37,        1,   622080, 0xc94a9707
-0,         38,         38,        1,   622080, 0xb5727fd4
-0,         39,         39,        1,   622080, 0x143c018c
-0,         40,         40,        1,   622080, 0x92d110c9
-0,         41,         41,        1,   622080, 0x4f762fc0
-0,         42,         42,        1,   622080, 0x3dd2a7d2
-0,         43,         43,        1,   622080, 0xa5d02dc0
-0,         44,         44,        1,   622080, 0x2223ce3d
-0,         45,         45,        1,   622080, 0xe4a5fc36
-0,         46,         46,        1,   622080, 0x8384159e
-0,         47,         47,        1,   622080, 0x995efa57
+0,         18,         18,        1,   622080, 0xb9a21d81
+0,         19,         19,        1,   622080, 0xcad5045c
+0,         20,         20,        1,   622080, 0xb3515cee
+0,         21,         21,        1,   622080, 0xf3617e04
+0,         22,         22,        1,   622080, 0x920ccb46
+0,         23,         23,        1,   622080, 0x0d6bf5ee
+0,         24,         24,        1,   622080, 0x3824bfa3
+0,         25,         25,        1,   622080, 0x966ed01f
+0,         26,         26,        1,   622080, 0x59dedfca
+0,         27,         27,        1,   622080, 0xc4d9f060
+0,         28,         28,        1,   622080, 0xfc425c54
+0,         29,         29,        1,   622080, 0xd4d79d89
+0,         30,         30,        1,   622080, 0x26112cde
+0,         31,         31,        1,   622080, 0xcedc47e5
+0,         32,         32,        1,   622080, 0x8a5962f3
+0,         33,         33,        1,   622080, 0x290d9d70
+0,         34,         34,        1,   622080, 0xc173ca6e
+0,         35,         35,        1,   622080, 0x3bc28ba3
+0,         36,         36,        1,   622080, 0x0450ca38
+0,         37,         37,        1,   622080, 0x66e5065c
+0,         38,         38,        1,   622080, 0x4b26ee9f
+0,         39,         39,        1,   622080, 0x3cb19ecf
+0,         40,         40,        1,   622080, 0x670d4d1b
+0,         41,         41,        1,   622080, 0x18b2fc90
+0,         42,         42,        1,   622080, 0x74134131
+0,         43,         43,        1,   622080, 0x36cfa8dc
+0,         44,         44,        1,   622080, 0xefef09d4
+0,         45,         45,        1,   622080, 0x0aa0a8f6
+0,         46,         46,        1,   622080, 0x3a7b42f3
+0,         47,         47,        1,   622080, 0x2900da5d
TEST    filter-codecview-mvs
Test filter-w3fdif-simple failed. Look at tests/data/fate/filter-w3fdif-simple.err for details.
make: *** [fate-filter-w3fdif-simple] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/fate/filter-w3fdif-complex      2015-07-11 21:11:06.220922890 +0200
+++ tests/data/fate/filter-w3fdif-complex       2015-07-11 21:36:10.976954590 +0200
@@ -1,31 +1,31 @@
 #tb 0: 1/50
-0,         18,         18,        1,   622080, 0x21d21485
-0,         19,         19,        1,   622080, 0x600a5468
-0,         20,         20,        1,   622080, 0x9526f7b8
-0,         21,         21,        1,   622080, 0x8b3e661f
-0,         22,         22,        1,   622080, 0xff5cb5a9
-0,         23,         23,        1,   622080, 0x7e5e730c
-0,         24,         24,        1,   622080, 0x85219ac6
-0,         25,         25,        1,   622080, 0x2f3465a0
-0,         26,         26,        1,   622080, 0xddbf4da0
-0,         27,         27,        1,   622080, 0xc115d4ee
-0,         28,         28,        1,   622080, 0x7a8a8d72
-0,         29,         29,        1,   622080, 0xbafcd973
-0,         30,         30,        1,   622080, 0xd2c15603
-0,         31,         31,        1,   622080, 0xd7217855
-0,         32,         32,        1,   622080, 0x9a584eca
-0,         33,         33,        1,   622080, 0x9f3e1c40
-0,         34,         34,        1,   622080, 0x6d01efb7
-0,         35,         35,        1,   622080, 0x9ecfcce0
-0,         36,         36,        1,   622080, 0xb355fd7e
-0,         37,         37,        1,   622080, 0xc7784021
-0,         38,         38,        1,   622080, 0x13fe4187
-0,         39,         39,        1,   622080, 0xfa03b613
-0,         40,         40,        1,   622080, 0x2c9ccfcd
-0,         41,         41,        1,   622080, 0xcae6e6c6
-0,         42,         42,        1,   622080, 0x177968f9
-0,         43,         43,        1,   622080, 0xf708de36
-0,         44,         44,        1,   622080, 0x4491870a
-0,         45,         45,        1,   622080, 0x37709f98
-0,         46,         46,        1,   622080, 0x23e8d22f
-0,         47,         47,        1,   622080, 0x25cba876
+0,         18,         18,        1,   622080, 0xab28bb74
+0,         19,         19,        1,   622080, 0x6076bb20
+0,         20,         20,        1,   622080, 0x2a7415ee
+0,         21,         21,        1,   622080, 0x9b993386
+0,         22,         22,        1,   622080, 0x8a7e7c00
+0,         23,         23,        1,   622080, 0xea03ad27
+0,         24,         24,        1,   622080, 0xc5a974ed
+0,         25,         25,        1,   622080, 0x979785e6
+0,         26,         26,        1,   622080, 0x8af69403
+0,         27,         27,        1,   622080, 0x7955a583
+0,         28,         28,        1,   622080, 0xe9ac138b
+0,         29,         29,        1,   622080, 0xd7f55197
+0,         30,         30,        1,   622080, 0x1572e2c7
+0,         31,         31,        1,   622080, 0x1a48fdd1
+0,         32,         32,        1,   622080, 0x861f1b5c
+0,         33,         33,        1,   622080, 0xcf0251c8
+0,         34,         34,        1,   622080, 0x744580f0
+0,         35,         35,        1,   622080, 0x01a84391
+0,         36,         36,        1,   622080, 0x1e168290
+0,         37,         37,        1,   622080, 0xfb60bb7c
+0,         38,         38,        1,   622080, 0x9315a4ce
+0,         39,         39,        1,   622080, 0xb170582d
+0,         40,         40,        1,   622080, 0x307f06aa
+0,         41,         41,        1,   622080, 0x81b2b887
+0,         42,         42,        1,   622080, 0x0cdafbeb
+0,         43,         43,        1,   622080, 0x0c6a5f4f
+0,         44,         44,        1,   622080, 0x0f0cbf6c
+0,         45,         45,        1,   622080, 0xeb8b5cb2
+0,         46,         46,        1,   622080, 0xc619f42b
+0,         47,         47,        1,   622080, 0x2a9c9139
Test filter-w3fdif-complex failed. Look at tests/data/fate/filter-w3fdif-complex.err for details.
make: *** [fate-filter-w3fdif-complex] Error 1


[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150711/3b887f11/attachment.sig>


More information about the ffmpeg-devel mailing list