[FFmpeg-devel] [libav-devel] [PATCH] riffdec: error out on negative bit rate

[Michael Niedermayer]

On Sat, Jul 11, 2015 at 05:22:16PM +0200, Andreas Cadhalpun wrote:
> On 11.07.2015 11:44, Luca Barbato wrote:
> > On 11/07/15 01:26, Andreas Cadhalpun wrote:
> >> Note however that the explode mode doesn't necessarily work, because e.g.
> >> the avi demuxer doesn't set err_recognition for the AVCodecContext.
> > 
> > It wouldn't work as intended, setting the bit_rate to 0 thought, does
> > prevent an issue with g726 but probably that chunk of code could be removed.
> > 
> > Some patches following...
> 
> After your riff patch, it is possible to the the explode mode working.
> Updated patch attached.
> 
> Best regards,
> Andreas
> 

>  riffdec.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> be94fc631be0efc96382ff0d4b84c2fb525b0a0e  0001-riffdec-prevent-negative-bit-rate.patch
> From e7634d4f175841285d5481ef951c62c704efbcc3 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sat, 11 Jul 2015 00:09:46 +0200
> Subject: [PATCH] riffdec: prevent negative bit rate
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150712/d35262ee/attachment.sig>