[FFmpeg-devel] libavcodec/qsvdec_h264.c: SPS parsing now performs by MFXVideoDECODE_DecodeHeader() into libavcodec/qsvdec.c

Michael Niedermayer michael at niedermayer.cc
Fri Jul 17 02:25:20 CEST 2015

On Fri, Jul 17, 2015 at 01:13:41AM +0300, Ivan Uskov wrote:
> Hello Hendrik,
> Ok, no problem. I will ask. But in general it makes no sense. I have
> got enough experience for MXF using and common transcoding developing
> to see that current implementation is not good and dangerous.
> I should to say that actually I see lot minor issues and quite ugly
> code pieces into QSV-related modules.
> I have got big doubts that all that was "by specific reason".
> For example discussed code piece not able to handle a case when decoded
> stream begins from arbitrary place, not from SPS. Decoding fails. It
> is common scenario for MPEG TS decoding.
> Also current code tries to handle dynamic SPS change at bad place (good
> place should be into the qsvdec.c) and by bad way (no fifo flush).
> My patch does not solve these issues but at least I have got clear
> roadmap in mind how to get qsv decoder more reliable and usable.
> It is just question of another patches.

> Should we keep this code which obvious bad?

no, bad code should be replaced by good or improved to become good

also maybe you want to send a patch to add yourself to the
MAINTAINERs file for qsv*


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150717/4167653d/attachment.sig>

More information about the ffmpeg-devel mailing list