[FFmpeg-devel] [PATCH] avformat: increase first_frames threshold for mp3, ac3

Ganesh Ajjanagadde gajjanag at mit.edu
Sat Jul 18 04:23:11 CEST 2015


Attached patch is a quick fix for Ticket4723.
I have a couple of issues with this though:
1. It seems like probe thresholds are essentially tweaked based on
what files are encountered, and that these can't be set precisely
according to a spec.
Is this correct?

2. Comment in the file mentions keeping probing in sync across ac3/mp3.
I kept this in mind for the patch, but don't know the rationale for this.

2. I tested the patch with fate and against the ticket.
However, ideally this should be tested against a variety of mp3/ac3 files,
to make sure the probing still works even with this stricter threshold
for detection.
Where can I find comprehensive sample files for this purpose,
and more generally audio/video files for ffmpeg development?

Thanks,
Ganesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-increase-first_frames-threshold-for-mp3-ac3.patch
Type: text/x-patch
Size: 1812 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150717/e90ac585/attachment.bin>


More information about the ffmpeg-devel mailing list