[FFmpeg-devel] [PATCH] avfilter: Add reverse filter

Clément Bœsch u at pkh.me
Sun Jul 19 14:13:33 CEST 2015


On Thu, Jul 16, 2015 at 09:01:53PM +0100, Derek Buitenhuis wrote:
> On Thu, Jul 16, 2015 at 7:43 PM, Clément Bœsch <u at pkh.me> wrote:
> >> +Reverses a clip. Requires memory to buffer the entire clip, so trimming is suggested.
> >
> > We use infinitive form, so "Reverse".
> 
> Done locally.
> 
> > You might want to print "Warning: this filter requires ..."
> 
> Is there any reasonable way to determine when to print such a warning? Seems
> silly to warn over e.g. 40 frames.
> 

I meant in the documentation. I don't know for the code.

> > Can you add an example to make sure users don't membomb too much their
> > OS?
> 
> How does this look:
> 
>     -vf trim=end=10,reverse
> 

Sure. Look how other examples are formatted and fine with me.

> >> +    if (ret == AVERROR_EOF && !ctx->is_disabled && s->nb_frames > 0) {
> >
> > is_disabled suggest a timeline support. You could add that if you feel
> > like it. That way, "reverse=enable='between(t,30,40)'" would reverse only
> > between t=30 and t=40 and pass through the rest of the time.
> 
> So the other option is to remove the check for it?
> 

Yes, it's always 0 currently since you didn't add the timeline flag.

> - Derek

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150719/15b4c213/attachment.sig>


More information about the ffmpeg-devel mailing list