[FFmpeg-devel] [PATCH 3/3] avdevice/decklink: Add support for decoding 8-bit RGB formats.

[Carl Eugen Hoyos]

Chris Spencer <spencercw <at> gmail.com> writes:

> -On Windows, you need to run the IDL files through  <at> command{widl}.
> +On Windows, you need to run the IDL files through  <at> command{midl}.

Is this intended?

> -DeckLink is very picky about the formats it supports. Pixel format is

> +DeckLink is very picky about the formats it supports. Pixel 
> format is uyvy422,

Imo, please do not change this line:
Going through old commits is not unusual, 
such changes make this much more difficult.

> +    } else if (cctx->pixel_format == AV_PIX_FMT_ARGB) {
> +        ctx->bmd_format = bmdFormat8BitARGB;
> +    } else if (cctx->pixel_format == AV_PIX_FMT_BGRA) {
> +        ctx->bmd_format = bmdFormat8BitBGRA;

> +    } else if (ctx->bmd_format == bmdFormat8BitARGB) {
> +        st->codec->codec_id    = AV_CODEC_ID_RAWVIDEO;
> +        st->codec->pix_fmt     = AV_PIX_FMT_ARGB;
> +        st->codec->codec_tag   = MKTAG('A', 'R', 'G', 'B');
> +    } else if (ctx->bmd_format == bmdFormat8BitBGRA) {
> +        st->codec->codec_id    = AV_CODEC_ID_RAWVIDEO;
> +        st->codec->pix_fmt     = AV_PIX_FMT_BGRA;
> +        st->codec->codec_tag   = MKTAG('B', 'G', 'R', 'A');

I would have expected these to be AV_PIX_FMT_0RGB and 
AV_PIX_FMT_BGR0.

> +    { "pixel_format", "set video pixel format"               , 

Should be pix_fmt imo.

Carl Eugen