[FFmpeg-devel] [PATCH 1/3] aacdec: move the LTP and TNS tables out of aacdectab.h

Nedeljko Babic Nedeljko.Babic at imgtec.com
Mon Jul 20 17:52:18 CEST 2015

>Thanks for your response.
>If you are okay with it then it would make sense to push this patch to
>master first then because you have to rebase aactab.* to INTFLOATs anyway.

I am ok with that.

As I said, I don't have a problem to make necessary changes to my patch set if
this patch is accepted first.

And it will probably be accepted first anyhow :)

>Could you consider moving ltp.c into the aacdec_template.c file? It's
>relatively short (compared to the decoder source) and it's only used a
>single time in the entire libavcodec by the aac decoder? Perhaps you can
>just inline the whole function in the decoder. When compiling aacdec_fixed
>it prints a warning saying it expects float * rather than an INTFLOAT *.

ltp.c? Are you sure that is the name of the file that is causing a problem?

The only warning of that type that I am having while building is in aacdec_template.c
and that is for ff_aac_eld_window_480 table.

The reason for this warning I explained in one of my previous mails.


More information about the ffmpeg-devel mailing list