[FFmpeg-devel] Fwd: [PATCH 1/2] ffmpeg: reset tty state correctly

[Ganesh Ajjanagadde]

Once again, apologies.

---------- Forwarded message ----------
From: Nicolas George <george at nsup.org>
Date: Mon, Jul 27, 2015 at 8:52 AM
Subject: Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: reset tty state correctly
To: Ganesh Ajjanagadde <gajjanagadde at gmail.com>


Le nonidi 9 thermidor, an CCXXIII, Ganesh Ajjanagadde a écrit :
> Apparently zsh was not doing it.

ttyctl -f

> Core is still being dumped due to the abort call.
> The handler is pretty minimal, just restoring tty state (necessary due
> to above), writing a message, and then calling abort.

It still obscures the state that caused the signal in the first place, and
thus make debugging harder. I consider this unacceptable and will still
object the patch.

Regarding casting to void: if there is no non-intrusive and portable to
silence that warning, then that warning is badly implemented and should be
disabled.

Note that you sent your replies to me only, not to the list: it is not a
good idea.

Regards,

--
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150727/4fa83c00/attachment.sig>