[FFmpeg-devel] [PATCH v5] Add support for Audible AA files

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Jul 30 10:33:20 CEST 2015

Vesselin Bontchev <vesselin.bontchev <at> yandex.com> writes:

> Is the licensing blurb okay now?

No objections from me, the "This file is part of" 
may be unnecessary.

> +    avio_read(pb, key, nkey); // key string

I may miss something but I wonder if there 
isn't a check missing if nkey is sane and 
if pb is long enough.

> +    if (c->aa_fixed_key_size != 16) { 
> // AVOption with a default value

Again: Where is this variable set?
You don't have to add a comment, just 
tell me, I don't see it.

> +    if (c->codec_second_size == -1) {
> +        return AVERROR_INVALIDDATA;

You could print something like "unknown 
codec %s" here.

> +    av_log(s, AV_LOG_DEBUG, "[aa] chapter %d (%ld bytes)

"PRId64" if the type of the variable is 

Carl Eugen

More information about the ffmpeg-devel mailing list