[FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

[Andreas Cadhalpun]

On 14.06.2015 23:32, Lou Logan wrote:
> On Sun, Jun 14, 2015, at 10:49 AM, Andreas Cadhalpun wrote:
>> --- a/libavcodec/ppc/me_cmp.c
>> +++ b/libavcodec/ppc/me_cmp.c
>> @@ -504,7 +504,7 @@ static int hadamard8_diff8x8_altivec(MpegEncContext
>> *s, uint8_t *dst,
>>  }
>>  
>>  /*
>> - * 16x8 works with 16 elements; it allows to avoid replicating loads,
>> and
>> + * 16x8 works with 16 elements; it allows one to avoid replicating
>> loads, and
> 
> Possible alternatives:
> 
> ...elements; it avoids replicating loads, and...
> ...elements; it can avoid replicating loads, and...

Both sound better, I picked the latter. ;)

>> --- a/libavcodec/x86/vc1dsp_mmx.c
>> +++ b/libavcodec/x86/vc1dsp_mmx.c
>> @@ -80,7 +80,7 @@
>>      "movq      %%mm"#R1", "#OFF"(%1)   \n\t"    \
>>      "add       %2, %0                  \n\t"
>>  
>> -/** Sacrifying mm6 allows to pipeline loads from src */
>> +/** Sacrifying mm6 makes it possible to pipeline loads from src */
> 
> "Sacrifying" looks like a typo for "Sacrificing", or it's a word I've
> never seen before.

Indeed, how could I miss that? Fixed.

> I'm not a fan of the "one" pronoun (I don't hear it much in 'Merican
> English), but the rest LGTM.

OK, I reworded the changes in avformat.h. New patch attached.

Best regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-doc-avoid-incorrect-phrase-allows-to.patch
Type: text/x-diff
Size: 8933 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150615/385d0c74/attachment.bin>