[FFmpeg-devel] [PATCH 7/8] ffmdec: don't return AVERROR(EAGAIN) from ffm_is_avail_data

[Michael Niedermayer]

On Mon, Mar 09, 2015 at 12:33:38PM +0100, Andreas Cadhalpun wrote:
> On 09.03.2015 03:56, Michael Niedermayer wrote:
> >On Mon, Mar 09, 2015 at 12:05:01AM +0100, Andreas Cadhalpun wrote:
> >>Hi,
> >>
> >>if AVERROR(EAGAIN) is returned from ffm_is_avail_data it always
> >>causes an infinite EAGAIN loop.
> >
> >it should only loop until more data is written into the ffm file
> >(this of course is not guranteed to ever happen)
> 
> How should this work?
> 
> If ffm_is_avail_data returns AVERROR(EAGAIN), this error is
> immediately forwarded to avformat_find_stream_info, which just tries
> reading a frame again, leading to ffm_read_packet, which first calls
> ffm_is_avail_data.
> Nothing changed the FFMContext, even if more data was written into
> the ffm file, so it returns AVERROR(EAGAIN) again.

ffm_set_write_index() from ffserver could, this looks like ffm should
export a clean API to be used by ffserver though
also we really need regression tests for this ...

CCing reynaldo as he probably knows the code better 

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150309/81a1eac9/attachment.asc>