[FFmpeg-devel] [PATCH] x86/swr: fix pack_8ch functions on compilers without aligned stack

[Ronald S. Bultje]

Hi,

On Wed, May 13, 2015 at 7:18 AM, Ronald S. Bultje <rsbultje at gmail.com>
wrote:

> Hi,
>
> On Wed, May 13, 2015 at 6:24 AM, Hendrik Leppkes <h.leppkes at gmail.com>
> wrote:
>
>> On Wed, May 13, 2015 at 12:09 PM, Rainer Hochecker
>> <fernetmenta at online.de> wrote:
>> > Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
>> >
>> >
>> >>
>> >> That sounds impossible since the patch was pushed as
>> >> http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=f7ed997a
>> >>
>> >> Carl Eugen
>> >>
>> >
>> > Why exactly is that impossible?
>> > It crashes in ff_pack_8ch_float_to_int32_a_sse2 on Windows.
>> > Same code, same scenario is fine on other platforms.
>> >
>>
>> Kodi's build script suggests that FFmpeg is build with gcc - this
>> crash and fix only ever applied to MSVC/ICL builds.
>
>
> Is the entry point (from msvc code of kodi into ffmpeg/gcc code) marked as
> realigning?
>

Seems it isn't:

$ grep attribute_align_arg ~/Projects/ffmpeg/libswresample/*.c
$

Check other libs for usage.

Ronald