[FFmpeg-devel] [PATCH] boxblur: Templatize blur{8,16}

Timothy Gu timothygu99 at gmail.com
Sun Nov 1 20:41:00 CET 2015

On Sun, Nov 1, 2015 at 11:10 AM Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:

> Have not tested, but just a general comment. Personally, I follow the
> twice repition is ok, thrice means it is good to factor out. I would
> have been happier if the diff-stat was better than 44+/66- in terms of
> deletions.

The most significant reason why the addition is as high as it is is the
comment describing the algorithm. Without taking into account the 14-line
comment, the diffstat would be 30+/52-, i.e. 1.73x.

The only part of the function that is different is the prototype, which I
believe is small enough to warrant a refactoring.


More information about the ffmpeg-devel mailing list