[FFmpeg-devel] [PATCHv3 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

Sebastian Dröge slomo at coaxion.net
Mon Nov 2 16:53:56 CET 2015

On Mo, 2015-11-02 at 15:12 +0000, Carl Eugen Hoyos wrote:
> Sebastian Dröge <slomo <at> coaxion.net> writes:
> > +            if (ts_st->opus_pending_trim_start)
> > +              ctrl_header_size += 2;
> > +            if (trim_end)
> > +              ctrl_header_size += 2;
> You could move the additions inside the larger if 
> blocks below, that would make the code slightly 
> cleaner imo, feel free to ignore.

Thanks for the review!

That's not possible as this size is used for av_malloc(). I guess I
could always allocate the maximum size and make it smaller in the end,
if you prefer that.

> Could you clarify that the specification was fixed?
> I believe it wasn't some time ago or am I wrong?

What was wrong with the specification? The au_size of the control
header is wrong and going to be (or already is?) changed to be how it's
used in ffmpeg in the demuxer and in obe.tv's muxer. Apart from that
I'm not aware of any problems.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: This is a digitally signed message part
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151102/04713475/attachment.sig>

More information about the ffmpeg-devel mailing list