[FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

Michael Niedermayer michael at niedermayer.cc
Fri Nov 6 10:54:28 CET 2015

On Fri, Nov 06, 2015 at 08:52:32AM +0100, Nicolas George wrote:
> Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit :
> > iam with whatever default people prefer
> IIRC, the current default yields different results when rematrixing from
> float to float and then converting from float to int than when doing both in
> a single step.

yes, OTOH float -> float rematrix + "inverse" float->float should be
closer to the original than with the changed default
The difference between the defaults is in volume of the output

> I beliee this is not good.

no its not good, though the alternative isnt really good either.
All choices have some kind of disadvantage. There also would be the
possibility of implementing 2 pass mode to maintain the volume as much
as possible without cliping (but that could not easily be default)
For the default, the question is what people prefer ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151106/e2aee51d/attachment.sig>

More information about the ffmpeg-devel mailing list