[FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

Michael Niedermayer michael at niedermayer.cc
Sat Nov 7 22:57:28 CET 2015

On Sat, Nov 07, 2015 at 10:49:42PM +0100, wm4 wrote:
> On Sat, 7 Nov 2015 20:00:50 +0000
> Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> > On 11/7/2015 7:35 PM, Paul B Mahol wrote:
> > > AFAIK changing option from int to double will break programs which
> > > assume opttions is int.  
> > 
> > Not really sure how it could. The original range allowed was [2,16],
> > and using any of the av_opt_set functions should still work with that, 
> > no?
> A program could use av_opt_find() and then compute the pointer to the
> option and set it manually.
> Is this valid API usage? Well, can you really tell? Or anyone? I've
> certainly seen at least one program do this with another option.

its certainly valid API usage to scan the options and extract the
types. But IMO the types are not part of the ABI/API, an application
doing that should be able to handle cases where the type changed
AVOptions would be less usefull if types (and offsets) could not
And yes we probably should document this if all agree that this is
how it should work

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151107/cea58aad/attachment.sig>

More information about the ffmpeg-devel mailing list