[FFmpeg-devel] [PATCH 1/4] lavc/internal: add FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

[Michael Niedermayer]

On Sun, Nov 08, 2015 at 06:17:49PM +0100, Matthieu Bouron wrote:
> On Tue, Nov 3, 2015 at 9:02 PM, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Mon, Nov 02, 2015 at 11:45:05AM +0100, Matthieu Bouron wrote:
> > > From: Matthieu Bouron <matthieu.bouron at stupeflix.com>
> > >
> > > Codec supporting FF_CODEC_SKIP_FRAME_FILL must still extract and fill
> > > their parameters into AVCodecContext while honoring the skip_frame
> > > flag.
> > > ---
> > >  libavcodec/internal.h | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/libavcodec/internal.h b/libavcodec/internal.h
> > > index 0abe17f..a023d1a 100644
> > > --- a/libavcodec/internal.h
> > > +++ b/libavcodec/internal.h
> > > @@ -53,6 +53,11 @@
> > >   * from the input AVPacket.
> > >   */
> > >  #define FF_CODEC_CAP_SETS_PKT_DTS           (1 << 2)
> > > +/**
> > > + * Codec still extract and fill its parameters even if the skip_frame
> > > + * parameter is honored.
> >
> > iam not sure about the english grammer here sounds a bit odd but
> > otherwise the patch LGTM
> >
> 
> If you have a better sentence or someone else does, I would be happy to
> update the current one before i push the patch.

maybe something like:
The decoder extracts and fills its parameters even if the frame is
skiped due to the skip_frame setting


> 
> Matthieu
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151108/f87fbd5d/attachment.sig>