[FFmpeg-devel] [PATCH 2/4] concatdec: factorize duration calculating code to get_duration function

Nicolas George george at nsup.org
Mon Nov 9 08:37:49 CET 2015

Le duodi 12 brumaire, an CCXXIV, Marton Balint a écrit :
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/concatdec.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

I do not object, but I find that this part of the code is starting to become
quite convoluted. Are you sure it is really necessary. I understand that you
want to use the duration for the metadata that will be later used in the
select filter. Surely this information is only useful is the duration is
reliable? So instead of changing this part, I suspect you could set the
duration metadata only if the duration is already known, i.e. authoritative
or reliable.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151109/fdc0ff98/attachment.sig>

More information about the ffmpeg-devel mailing list