[FFmpeg-devel] [PATCH] avformat/cache: Avoid int-overflow in cache compare function

Michael Niedermayer michael at niedermayer.cc
Mon Nov 9 21:53:26 CET 2015

On Sun, Nov 08, 2015 at 04:35:01PM -0800, Bryan Huh wrote:
> cache protocol indexes its cache using AVTreeNodes which require a cmp
> function for inserting and searching new cache-entries. This cmp
> function expects a 32-bit int return value (negative, zero, or positive)
> but the cache cmp function returns an int64_t which can overflow the
> int, giving negative numbers for when it should be positive, vice versa.
> This manifests itself only for very large files (e.g. 4GB+)
> ---
>  libavformat/cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151109/31b05369/attachment.sig>

More information about the ffmpeg-devel mailing list