[FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI
ivan.uskov at nablet.com
Thu Nov 12 12:13:08 CET 2015
Thursday, November 12, 2015, 12:53:46 AM, you wrote:
WK> On 11/07, Ivan Uskov wrote:
>> Although the code looks ok by itself, I believe it is bad idea to place
>> H.264-specific code to the function which is common for all
>> encoders. I believe H.264-specific user data insertion should locates into
>> the qsvenc_h264.c
>> I.e. there is necessary some kind of 'SetEncodeCtrl' callback which points to
>> function into the encoder-specific module.
>> I believe if you will define a callback pointer QSVEncContext::SetEncodeCtrlCB,
>> setup it into qsv_enc_init() of the qsvenc_h264.c and call if it non-zero
>> from ff_qsv_encode() we will have good base to extend add user data for
>> MPEG2 later. Else we will get very bulky and ugly ff_qsv_encode().
>> I can release something but I hope you will able to catch my idea.
>> Please let me know if something is unclear.
WK> Hi Ivan,
WK> Here is an updated patch. Let me know if this is what you were thinking.
I'm like and agree this implementation, no questions from my side. Thank!
Ivan mailto:ivan.uskov at nablet.com
More information about the ffmpeg-devel