[FFmpeg-devel] [libav-devel] [PATCH 3/4] dds: make sure pallete frame buffer exists before use

Andreas Cadhalpun andreas.cadhalpun at gmail.com
Fri Nov 13 22:01:01 CET 2015

On 13.11.2015 02:08, Vittorio Giovara wrote:
> oh I see, that can happen for a special crafted file, DDPF_FOURCC has
> been introduced recently while DDPF_PALETTE has been removed, so a
> normal file should not have both set.

OK, that makes sense.

> Because of that, and how rare palette dds are, I think it's quite safe
> to unset ctx->paletted if ctx->compressed is set, and be done with it.

Patch doing that is attached.

> That is the only case I can see that happen, right?

Yes, that's the only case.

> Thanks for the catch, how did you find it btw? :)

Like all the other: with afl [1].
It's really good at finding weird cases. ;)

Best regards,

1: http://lcamtuf.coredump.cx/afl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dds-disable-palette-flag-for-compressed-dds.patch
Type: text/x-diff
Size: 1106 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151113/e729b0db/attachment.patch>

More information about the ffmpeg-devel mailing list