[FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

[Michael Bradshaw]

On Wed, Nov 18, 2015 at 6:21 AM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 11/17/2015 3:27 PM, Michael Bradshaw wrote:
> > Attached patch adds support for OpenJPEG 2.0/2.1. Please review.
>
> This seems like quite a large change. Does it perhaps warrant its own
> file/decoder name?


I thought about it, but it shares a lot of functionality with the 1.x code,
including program options (the only difference being the OPJ_ prefix in
2.x).

I could rip out all the common functionality into some shared
libopenjpeg.h/c files, and replace the program options with custom values
that each codec then translates into OpenJPEG's option values, and then
have two codecs for 1.x and 2.x. The logic in that case will be simpler to
follow because there won't be as many macros, but overall it will be a
larger change.

Opinions?