[FFmpeg-devel] [PATCH 00/10] use hypot throughout FFmpeg

Ganesh Ajjanagadde gajjanagadde at gmail.com
Sun Nov 22 18:05:40 CET 2015

Turns out hypot fallback added recently is currently not needed in the sense that
no regressions have been observed from earlier commit
However, I do not consider this sufficient justification for reverting
associated configure checks and fallback, simply because there can very well exist
platforms lacking this especially since it is C99, that are not tested by FATE.

Anyway, this series adds hypot whenever useful throughout FFmpeg by running a
manual audit for sqrt usage and modifying accordingly.

8/10 was just a trivial thing I noticed while working on this stuff.

Patches tested with FATE on x86-64, GNU/Linux.

Ganesh Ajjanagadde (10):
  avformat/mov: use hypot()
  ffplay: use hypot()
  avcodec/aacps_tablegen: use hypot()
  avfilter/af_compand: use hypot()
  avfilter/avf_showcqt: use hypot()
  avfilter/vf_chromakey: use hypot()
  avfilter/vf_codecview: use hypot()
  avfilter/vf_colorkey: avoid unnecessary floating point multiply
  avfilter/vsrc_mandelbrot: use hypot()
  avfilter/vsrc_mptestsrc: use hypot()

 ffplay.c                      | 6 +++---
 libavcodec/aacps_tablegen.h   | 2 +-
 libavfilter/af_compand.c      | 4 ++--
 libavfilter/avf_showcqt.c     | 2 +-
 libavfilter/vf_chromakey.c    | 2 +-
 libavfilter/vf_codecview.c    | 2 +-
 libavfilter/vf_colorkey.c     | 2 +-
 libavfilter/vsrc_mandelbrot.c | 2 +-
 libavfilter/vsrc_mptestsrc.c  | 2 +-
 libavformat/mov.c             | 3 +--
 10 files changed, 13 insertions(+), 14 deletions(-)


More information about the ffmpeg-devel mailing list