[FFmpeg-devel] [PATCH]lavc/opusdec: Fix a memleak when reading invalid files

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Nov 26 00:51:09 CET 2015


On Friday 20 November 2015 02:59:34 am James Almer wrote:
> On 11/19/2015 10:05 PM, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > Attached patch fixes a memleak with the sample from bug 909.

> >      /* find out the channel configuration */
> >      ret = ff_opus_parse_extradata(avctx, c);
> > -    if (ret < 0)
> > +    if (ret < 0) {
> > +        av_freep(&c->fdsp);
> >          return ret;
>
> ff_opus_parse_extradata() can allocate s->channel_maps, so i think it
> should also be freed here.
>
> LGTM aside from that.

I have applied the patch with this change.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list