[FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

Nicolas George george at nsup.org
Thu Nov 26 20:46:25 CET 2015

Le sextidi 6 frimaire, an CCXXIV, wm4 a écrit :
> Better do the looping internal in flvdec.c (if there's no huge number
> of other demuxers which need this), instead of adding a new error code
> that is also part of the public API.

There are a few, but not many. This was my first intent, but looping in the
framework is way more elegant and much cleaner design.

Nothing would prevent us from defining the error code in
libavformat/internal.h if we make sure it does not leaks to the application,
but as Michael mentioned earlier and I did in the comments for patch 2/3 in
this series, having a public code allows to give the application
fine-grained control over the looping, for example to maintain basic user
interaction while a demuxer tries to find a sync word in a big corrupted
file on a slow local medium.

Therefore, I maintain the proposed patch as is.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151126/80519dff/attachment.sig>

More information about the ffmpeg-devel mailing list