[FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

Hendrik Leppkes h.leppkes at gmail.com
Fri Nov 27 18:50:15 CET 2015

On Fri, Nov 27, 2015 at 6:40 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> On Fri, 2015-11-27 at 09:08 -0800, Timothy Gu wrote:
>> On Fri, Nov 27, 2015 at 03:08:05PM +0000, Rostislav Pehlivanov wrote:
>> > I've just pushed a patch which makes the AAC encoder threadsafe, so
>> > now
>> > it should be safe to always generate that table at runtime.
>> This commit seems to break FATE on a couple of platforms (not sure
>> about
>> Linux yet but probably). See:
> I'm on it. Freenode is dead for me ATM.
> It's the aac-fixed decoder again.

Note that the init is wrong for float as well. You use the same
condition for aacenc and aacdec, but they init different things.
aacdec inits much more, and if aacenc would init first for some
reason, it would leave aacdec without half its init.

More information about the ffmpeg-devel mailing list