[FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization
gajjanag at mit.edu
Fri Nov 27 21:59:48 CET 2015
On Fri, Nov 27, 2015 at 1:00 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> On Fri, 2015-11-27 at 18:50 +0100, Hendrik Leppkes wrote:
>> Note that the init is wrong for float as well. You use the same
>> condition for aacenc and aacdec, but they init different things.
>> aacdec inits much more, and if aacenc would init first for some
>> reason, it would leave aacdec without half its init.
> Yes, realized that. Partially reverted the patch. Now the aac encoder
> and decoder can init the table twice but this is less than an evil than
> the alternative. So I think it might just be better to leave things as
> they were and live with initializing it twice in case someone
> transcodes aac->aac using the native encoder.
> On Fri, 2015-11-27 at 18:37 +0100, wm4 wrote:
>> Such changes should be put up for review anyway.
> Was on the fence about whether to put it up for review but it seemed
> like a small patch.
I get build failures starting with commit
@Rostislav: can you check, reproduce, and resolve this?
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel