[FFmpeg-devel] [PATCH] avcodec/aac_tablegen: get rid of hardcoded tables entirely
gajjanag at mit.edu
Sat Nov 28 01:39:08 CET 2015
On Fri, Nov 27, 2015 at 6:14 PM, Rostislav Pehlivanov
<atomnuker at gmail.com> wrote:
> On Fri, 2015-11-27 at 17:07 -0500, Ganesh Ajjanagadde wrote:
>> Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime
>> initialization cheap.
> Leaves a lot of the cruft around. aac_tablegen.h and
> aac_tablegen_decl.h are now quite unnecessary. I suggest getting rid of
> aac_tablegen* entirely and just moving everything entirely to aactab.h.
> Just move the function as a normal function in aactab.c (or just define
> it as a static inline in aactab.h since it's used only twice), define
> the 2 tables there and you'd be done.
I never really spent time understanding the header file, source file,
static, and extern stuff in C, and essentially just hacked around to
get something that builds cleanly and passes FATE. Someday, I need to
do this. With this caveat, have posted v2.
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel