[FFmpeg-devel] [PATCH] avcodec/mpegaudio_tablegen: more dynamic initialization speedups

Ronald S. Bultje rsbultje at gmail.com
Sat Nov 28 14:48:37 CET 2015


On Sat, Nov 28, 2015 at 12:46 AM, Ganesh Ajjanagadde <gajjanagadde at gmail.com
> wrote:

> I personally consider this net ~ 10x and overall perf numbers sufficient
> for using dynamic initialization all the time here, especially since the
> tables are large.

This is a logical fallacy. By this logic, I could post some really shitty
code, speed it up 10x and then say "I made it better so it should be
default", regardless of what the actual quality of the current code is.

If you want to argue for dynamic vs. static table default choice, you
should compare only these two currents (dynamic vs static), not the
improvement of an old dynamic vs current dynamic table generation.

(I have no opinion on which default should be chosen, although >1M
post-patch cycles seems like enough of a reason for me to say that static
tables serves a real use case, particularly on slower devices.)


More information about the ffmpeg-devel mailing list