[FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely
atomnuker at gmail.com
Sat Nov 28 16:06:41 CET 2015
On Sat, 2015-11-28 at 09:45 -0500, Ganesh Ajjanagadde wrote:
> Removed the av_cold, did not find a way to cleanly get rid of the
> inline. I do suggest giving it some thought; it is needless
> bloat since the inline does not help perf. Pushed, thanks.
Hardly a blot as it's really only used twice in the entire code and the
function isn't a particularly big one. Moreover even if it was a big
function used in a few more places GCC can and will magically uninline
it (which is why I'm not really a fan of using av_always_inline for
every single function which has to be inlined, better to let the
compiler figure it out and if it can't it'll just inline it anyway).
But I digress, the whole point of inlining this particlar function was
so it could be put inside the header and not inside aactab.c (which
contains no executable code at all).
More information about the ffmpeg-devel