[FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Nov 28 21:19:02 CET 2015

On 11/28/2015 7:51 PM, Ganesh Ajjanagadde wrote:
> In principle of course, e.g with more ifdefry, configure, or something
> of that sort. I do not believe this is what he meant.

I will await his reply to clarify, then. Perhaps do not write so matter-of-factly.

> In any case, the point is moot - the implementations are not broken -
> if they are, avutil/libm needs fixing as well.

Now, yes. It would certainly be nice if this was noted somewhere in the patch notes
(not necessarily in the commit messages). There are quite a few threads on the list
from you now regarding tablegen, and it can be a pain in the butt / tedious to figure
out how the current version differs from the N others.

>> Anyway, shouldn't this patce dropped, since 79abf2d0ded860acf505de22c4f7a750e5e98446
>> removed hardcoded tables anyway?
> No, if you actually read even the first line of the commit message,
> you can see it was only for aac, not for this patch series.

Indeed, I misread, and missed the 'aac_'. You could certainly be less of
an ass about it, though.

- Derek

More information about the ffmpeg-devel mailing list