[FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter
gajjanag at mit.edu
Sun Nov 29 14:25:05 CET 2015
On Sun, Nov 29, 2015 at 7:45 AM, Paul B Mahol <onemda at gmail.com> wrote:
> On 11/29/15, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
>> On Sat, Nov 28, 2015 at 6:21 PM, Ganesh Ajjanagadde <gajjanag at mit.edu>
>>> On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol <onemda at gmail.com> wrote:
>>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>>> + case SQUARE:
>>>> + val = (phs < 0.5) ? -1 : +1;
>>> Something I missed: consider using e.g FFSIGN(phs - 0.5) or FFSIGN(0.5
>>> - phase), can't recall.
>> This I still suggest for readability.
> Both produce differend md5 output.
May have to do with underflow, i.e numbers near 0.5. Anyway, if you
care about branchless code here, it may be worthwhile to test since it
is just the sign bit of the result. But it should not be worth it for
the first patch, especially since you seem to care about bit-exact
output with some reference point.
More information about the ffmpeg-devel